Skip to content

Conversation

gpeacock
Copy link
Collaborator

@gpeacock gpeacock commented Oct 4, 2025

This fixes a compatibility error with v1 manifests that had empty actions

Copy link

codecov bot commented Oct 4, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.41%. Comparing base (8bc2a1d) to head (0a2cd10).

Files with missing lines Patch % Lines
sdk/src/claim.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1477      +/-   ##
==========================================
- Coverage   78.41%   78.41%   -0.01%     
==========================================
  Files         162      162              
  Lines       39518    39523       +5     
==========================================
+ Hits        30989    30991       +2     
- Misses       8529     8532       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

codspeed-hq bot commented Oct 4, 2025

CodSpeed Performance Report

Merging #1477 will not alter performance

Comparing gpeacock/v1_empty_actions (0a2cd10) with main (8bc2a1d)

Summary

✅ 16 untouched
⏩ 2 skipped1

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@gpeacock gpeacock changed the title Gpeacock/v1 empty actions fix: Empty actions array should be allowed for v1 claim compatibility [CAI-9573] Oct 4, 2025
@gpeacock gpeacock requested review from dyro and tmathern October 4, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants